Summary

The `upgradeTier` function incorrectly emits the ** UserJoinedDAO** event when a user upgrades their tier within a sponsored DAO. This event is misleading because the user is not joining the DAO but rather upgrading their existing membership tier.

Vulnerability Details

In the upgradeTier function, the following line of code emits the UserJoinedDAO event:

This event is typically used to indicate that a user has joined a DAO. However, in this context, the user is upgrading their membership tier, not joining the DAO for the first time. Emitting the UserJoinedDAO event in this scenario can lead to confusion and misinterpretation of the contract's activity logs.

Impact

• The event logs will incorrectly show that the user has joined the DAO, which can confuse users, developers, and auditors who rely on these logs for tracking user actions.

Tools Used

Recommendations