Submission Details
Severity:
Incorrect assignment of function variable instead of storage variable in `updateDAOMembership`
Summary
The updateDAOMembershipfunction should be able to update the existing DAO's parameters but it updates the passed params of function instead of the original dao value.
Vulnerability Details
The function:
function updateDAOMembership(string calldata ensName, TierConfig[] memory tierConfigs)
...
// Preserve minted values and adjust the length of dao.tiers
for (uint256 i = 0; i < tierConfigs.length; i++) {
if (i < dao.tiers.length) {
@> tierConfigs[i].minted = dao.tiers[i].minted; //@audit - should be the opposite
}
}
...
}
Impact
mintedamount of DAO will never be able to be updated.
Tools Used
Manual review.
Recommendations
Flip the assignment:
dao.tiers[i].minted = tierConfigs[i].minted;
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
54128 USDC / LOC
14,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.