Project

One World
NFTDeFi
15,000 USDC
View results
Submission Details
Severity: low
Invalid

Lack of Transfer Restrictions for CurrencyManager

Issue: The CurrencyManager contract manages a list of whitelisted currencies, but there are no checks on the actual transfers for these currencies within MembershipFactory. This could allow unintended currencies to be transferred or approved to unauthorized addresses.

Exploit:

A malicious actor could add an unapproved currency through another function or exploit a vulnerability to bypass CurrencyManager, making unauthorized transactions with unsupported currencies.

  • POC:

    // Transfers could be made with unapproved currencies if CurrencyManager is bypassed.
    function addCurrency(address currency) external onlyRole(ADMIN_ROLE) {
    // Missing restrictions for unauthorized currency transfers.
    }

Impact: Unauthorized currencies or incorrect values could be used in the system, potentially causing misconfigurations or enabling malicious transactions with incorrect currencies.

Tools used : VSC, Github

Recommendation: Use CurrencyManager to enforce checks on all currency transfers or approvals in the MembershipFactory to ensure only whitelisted currencies are utilized

Updates

Lead Judging Commences

0xbrivan2 Lead Judge 9 months ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement
0xbrivan2 Lead Judge 9 months ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.