Project

One World
NFTDeFi
15,000 USDC
View results
Submission Details
Severity: medium
Invalid

User can overpay a price for joining a DAO

Summary

Joining a DAO is calling joinDAO and then transfering tokens from users wallet to the Membership contract, but it can be frontrunned by updating the price of a tier and thus making the user pay more than he is willing to

Vulnerability Details

https://github.com/Cyfrin/2024-11-one-world/blob/1e872c7ab393c380010a507398d4b4caca1ae32b/contracts/dao/MembershipFactory.sol#L147

Impact

Unhappy users because they overpayed for a tier

Tools Used

manual review

Recommendations

Add maximum price parameter for a user when calling joinDAO and check if tierPrice is less than or equal to maximum price sent by user

Updates

Lead Judging Commences

0xbrivan2 Lead Judge 9 months ago
Submission Judgement Published
Invalidated
Reason: Known issue

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.