Submission Details
Severity:
Missing a check in dealersHand
Summary
In function dealresHand is mising a check for cardValue ==0.
Vulnerability Details
When cardValue is being calculated we might get 13 % 13 from
uint256 cardValue = dealersDeck[player].dealersCards[i] % 13;
which will set the value to 0 and whitout the check 0 will be added to dealerTotal.
Impact
Whitout the check the dealer will have less point in total than he shoud.
Tools Used
Manuel review.
Recommendations
I recommend to include another check next to cardValue>=10, so if you recive 0 it will add 10 points to dealerTotal.
Updates
Lead Judging Commences
inallhonesty 11 months ago
Submission Judgement Published Assigned finding tags:
Asymmetric calculation of hands is rigged in the player`s favor.
Rewards breakdown
nSLOC
147This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.