Submission Details
Severity:
Public Functions Not Used Internally Could Be Marked `external`
Root Cause
Several functions are declared as public but are not called internally within the contract:
function startGame() public payable returns (uint256) { ... }
function hit() public { ... }
function call() public { ... }
function getPlayerCards(address player) public view returns (uint256[] memory) { ... }
function getDealerCards(address player) public view returns (uint256[] memory) { ... }
Impact
Using public visibility for functions that are not called internally consumes more gas when they are called externally due to the additional code generated to support internal calls.
Recommendations
Change Visibility to
external: Mark functions asexternalif they are not called within the contract to optimize gas usage.Review Function Calls: Ensure that none of the functions are intended for internal use before changing their visibility.
Rewards breakdown
nSLOC
147This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.