Submission Details
Severity:
Dealer Loses Points When Card Value is Zero
Summary
Vulnerability Details
Currently, if the dealer draws a card with a value of 0, the dealer is assigned 0 points instead of 10 points. This causes the dealer to lose 10 points whenever they draw a card with a value of 0.
The issue lies in the following code:
function dealersHand(address player) public view returns (uint256) {
uint256 dealerTotal = 0;
for (uint256 i = 0; i < dealersDeck[player].dealersCards.length; i++) {
uint256 cardValue = dealersDeck[player].dealersCards[i] % 13;
@> if (cardValue >= 10) {
dealerTotal += 10;
} else {
dealerTotal += cardValue;
}
}
return dealerTotal;
}
Impact
The dealer loses 10 points every time they draw a card with a value of 0.
Tools Used
Manual Review
Recommendations
To fix this issue, modify the code to ensure the dealer gets 10 points when the card value is 0:
function dealersHand(address player) public view returns (uint256) {
uint256 dealerTotal = 0;
for (uint256 i = 0; i < dealersDeck[player].dealersCards.length; i++) {
uint256 cardValue = dealersDeck[player].dealersCards[i] % 13;
- if (cardValue >= 10) {
+ if (cardValue >= 10 || cardValue == 0) {
dealerTotal += 10;
} else {
dealerTotal += cardValue;
}
}
return dealerTotal;
}
Updates
Lead Judging Commences
inallhonesty 11 months ago
Submission Judgement Published Assigned finding tags:
Asymmetric calculation of hands is rigged in the player`s favor.
Rewards breakdown
nSLOC
147This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.