TwentyOne

First Flight #29
Beginner FriendlyGameFiFoundrySolidity
100 EXP
View results
Submission Details
Severity: medium
Invalid

Lack of access control in TwentyOne.sol : : getPlayerCards()

Summary

The getPlayerCard function lacks access control, allowing any address to unauthorized card viewing and accessing another player's game details

Vulnerability Details

function getPlayerCards (address player) public view returns (uint256[] memory) { //No Access Control
return playersDeck[player].playersCards;
}

Impact

Privacy violation and potential game exploitation

Tools Used

  • Manual code review

  • Foundry testing framework

  • Custom access control test

Recommendations

  • Add access modifiers

  • Implement role-based access control

  • Use require() statements to check sender permissions

Updates

Lead Judging Commences

inallhonesty Lead Judge 11 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.