TwentyOne

First Flight #29
Beginner FriendlyGameFiFoundrySolidity
100 EXP
View results
Submission Details
Severity: high
Invalid

Available Cards are stored on chain and could be seen by anyone, Not the matter of solidity variable visibility

Summary

The data stored on chain can be seen by anyone, and can be read from the blockchain by just the basic knowledge of it.
`TwentyOne::availableCards` have "private" visibility but it can be seen by anyone, by reading from the blockchain directly

Vulnerability Details

The basic rule of black jack states that the available cards should be hidden from the players but in the `TwentyOne::availableCards`, although having a private visibility it can be accessed by the off chain methodologies

Impact

the avaible cards are public

Tools Used

Recommendations

Due to this the structure of the game is completely unmangable and this can be fixed eigther storing the varibles that should be private off-chain or Re-structuring the whole the smart contract could be one fix for it

Updates

Lead Judging Commences

inallhonesty Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.