Submission Details
Severity:
Incorrect Calculation of Dealer's Total
Summary
The dealersHand function in the Solidity contract contains a logical flaw in how the dealer's hand total is calculated, specifically regarding the handling of Ace cards (represented by a 0 value). The current implementation does not correctly treat the Ace as either 1 or 11 based on the context of the hand. This oversight can lead to incorrect dealer hand totals and impact the fairness and integrity of the game.
Impact
Incorrect calculation of the dealer's total, affecting game outcomes.
Tools Used
Manual
Recommendations
function dealersHand(address player) public view returns (uint256) {
uint256 dealerTotal = 0;
for (uint256 i = 0; i < dealersDeck[player].dealersCards.length; i++) {
uint256 cardValue = dealersDeck[player].dealersCards[i] % 13;
- if (cardValue >= 10) {
+ if (cardValue == 0 || cardValue >= 10) {
dealerTotal += 10;
} else {
dealerTotal += cardValue;
}
}
return dealerTotal;
}
Updates
Lead Judging Commences
inallhonesty 6 months ago
Submission Judgement Published Assigned finding tags:
Asymmetric calculation of hands is rigged in the player`s favor.
Rewards breakdown
nSLOC
147This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.