Summary: Player can put more then 1eth

Vulnerability Details : The startGame() function allows the player to send exactly 1 Ether to initiate the game. However, the test suggests that this function does not restrict the maximum amount of Ether a player can send, leaving the contract open to the possibility of arbitrary Ether contributions. Even if the player sends more than 1 Ether, the game logic in endGame always transfers a fixed 2 Ether reward, regardless of the player's original deposit. This creates an imbalance in the payout system, where the payout does not scale with the player's contribution.

POC:

Impact: Players could send more than 1 Ether but still receive only 2 Ether as a reward. This results in an unfair situation where the player's initial deposit is not proportionally rewarded.

Tools Used: Foundry

Recommendations: Impose a Maximum Deposit: Modify the startGame function to impose a cap on the amount of Ether a player can deposit. This prevents excessive deposits and ensures a more balanced gameplay experience.

Example:

or Adjust Reward Mechanism: Modify the endGame function to make the reward proportional to the player's contribution, ensuring fairness. Example: