Submission Details
Severity:
Function `hit` does not return value for cards
Summary
After calling the hit function, users do not receive any immediate information about the final total value of their cards. Instead, they must invoke the playersHand function to determine whether to receive another card or stop.
Impact
Lack of real-time feedback and increased function calls: Users cannot see their cards value immediately after hitting, forcing them to repeatedly call playerHand to assess their situation.
Tools Used
Manual code review.
Recommendations
Apply this code:
+ function hit() public returns(uint256) {
require(
playersDeck[msg.sender].playersCards.length > 0,
"Game not started"
);
uint256 handBefore = playersHand(msg.sender);
require(handBefore <= 21, "User is bust");
uint256 newCard = drawCard(msg.sender);
addCardForPlayer(msg.sender, newCard);
uint256 handAfter = playersHand(msg.sender);
if (handAfter > 21) {
emit PlayerLostTheGame("Player is bust", handAfter);
endGame(msg.sender, false);
}
+ return handAfter;
}
Rewards breakdown
nSLOC
147This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.