TwentyOne

First Flight #29
Beginner FriendlyGameFiFoundrySolidity
100 EXP
View results
Submission Details
Severity: low
Invalid

mapping visibility

Summary

The contract have two mapping, playersDeck and dealersDeck defined but these doesn't have any visibility defined.

Vulnerability Details

Both mapping are missing the visibility modifier.

mapping(address => PlayersCards) playersDeck;
mapping(address => DealersCards) dealersDeck;

Impact

Unmeasured Outcomes: Without visibility is hard to determinate if actions are achieving the intended goals.

Inefficiency: Resources might be misallocated becasue we can't see what works or what doesn't.

Tools Used

Manual review

Recommendations

Add visibility modifier like to both mapping.

mapping(address => PlayersCards) public playersDeck;
mapping(address => DealersCards) public dealersDeck;
Updates

Lead Judging Commences

inallhonesty Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Lack of quality

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.