Alchemix Transmuter
Alchemix
DeFiFoundrySolidity
16,653 OP
View results
Previous Next
Submission Details
Severity: low
Invalid

Low Severity Findings for StrategyArb.sol Contract

sonamakash54

Summary:

This report outlines low-severity findings in the StrategyArb.sol contract. While these issues do not pose critical risks, addressing them will enhance the contract's transparency, efficiency, and adherence to best practices. The findings focus on missing event emissions and validation checks, which could lead to inefficiencies, wasted gas, and challenges in off-chain monitoring. Each issue is detailed below, along with recommended fixes to improve the contract's overall robustness.

Findings

[Low-01] Missing Emit Events for Critical Functions

Description:
The functions setRouter, _deployFunds, and claimAndSwap lack event emissions to log important state changes. This reduces the ability of external systems and users to track and monitor the contract's operations effectively.

Affected Code:#L42-L45, L60-L64, L73-L80

function setRouter(address newRouter) external onlyOwner {
router = newRouter;
}
​
function _deployFunds(uint256 amount) internal { // Deploy funds logic
}
​
function claimAndSwap(uint256 amountClaim, uint256 minOut) external { // Claim and swap logic
}

Recommendation:
Add events to log critical state changes. Example:

event RouterUpdated(address indexed newRouter);
event FundsDeployed(uint256 amount);
event ClaimAndSwapExecuted(uint256 amountClaim, uint256 minOut);
​
emit RouterUpdated(newRouter);
emit FundsDeployed(amount);
emit ClaimAndSwapExecuted(amountClaim, minOut);

[Low-02] _amountClaim and _minOut Must Be Greater Than Zero in claimAndSwap

Description:
The claimAndSwap function does not validate the _amountClaim and _minOut parameters, allowing execution with zero values, leading to wasted gas or unintended behavior.

Affected Code:#L73-L80

function claimAndSwap(uint256 amountClaim, uint256 minOut) external { // Claim and swap logic
}

Recommendation:
Add validation checks to ensure inputs are greater than zero:

require(amountClaim > 0, "Amount to claim must be greater than zero");
require(minOut > 0, "Minimum output must be greater than zero");

[Low-03] _amount Must Be Greater Than Zero in _freeFunds

Description:
The _freeFunds function does not validate the _amount parameter, allowing execution with zero values, causing unnecessary gas waste and inefficiency.

Affected Code:#L115-L122

function _freeFunds(uint256 amount) internal { // Withdrawal logic
}

Recommendation:
Add a validation check for _amount:

require(amount > 0, "Amount must be greater than zero");

[Low-04] Missing Require Check for _amount in _deployFunds

Description:
The _deployFunds function does not validate that the _amount parameter is greater than zero, potentially leading to unnecessary operations with zero values and gas waste.

Affected Code:#L60-L64

function _deployFunds(uint256 amount) internal { // Deploy funds logic
}

Recommendation:
Add a validation check for _amount:

require(amount > 0, "Amount must be greater than zero");
Updates

Appeal created

inallhonesty Lead Judge 6 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
inallhonesty Lead Judge 6 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.