DeFiFoundrySolidity
16,653 OP
View results
Submission Details
Severity: high
Invalid

Insufficient Slippage Protection

Description: Weak slippage protection in swap functions across all strategies.

In StrategyArb:

Copyrequire(minOut > _amount, "minOut too low");

In StrategyMainnet and StrategyOp:

  • Similar minimal slippage checks

  • Potential for significant price manipulation

Impact:

  • Potential economic loss

  • Sandwich attack vulnerability

  • Unexpected swap outcomes

Proof of Concept:

function manipulateSwap() external {
// Minimal protection against price manipulation
uint256 maliciousMinOut = currentPrice * 99 / 100;
strategy.claimAndSwap(amount, maliciousMinOut, path);
}

Recommended Mitigation:

  • Implement more robust slippage calculations

  • Use external oracle price feeds

  • Add percentage-based slippage protection

  • Implement time-weighted average price (TWAP) mechanisms

Updates

Appeal created

inallhonesty Lead Judge 6 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
inallhonesty Lead Judge 6 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.