Submission Details
Severity:
State variable changes but no event is emitted in StrategyArb.sol, StrategyMainnet.sol and StrategyOp.sol.
Summary
Key state-changing functions lack event emissions, reducing on-chain transparency and composability.
Vulnerability Details
Three functions modify important state variables without emitting corresponding events:
Found in src/StrategyArb.sol [Line: 42]()
```solidity
function setRouter(address _router) external onlyManagement {
```
- Found in src/StrategyMainnet.sol [Line: 56]()
```solidity
function addRoute(
```
- Found in src/StrategyOp.sol [Line: 48]()
```solidity
function setRouter(address _router) external onlyManagement {
Impact
Reduces ability to track critical changes off-chain
Makes integration with monitoring tools more difficult
Decreases transparency for users and integrators
Tools Used
manuel code review
Recommendations
Add events for state changes:
event RouterUpdated(address indexed oldRouter, address indexed newRouter);
event RouteAdded(uint256 indexed routeId, address[11] route, address[5] pools);
function setRouter(address _router) external onlyManagement {
address oldRouter = router;
router = _router;
underlying.safeApprove(router, type(uint256).max);
emit RouterUpdated(oldRouter, _router);
}
Prize pool breakdown
Total prize
16,653 OP
nSLOC
25366 OP / LOC
15,800
853
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.