Submission Details
Severity:
Use inherited _deployFunds function to maintain compatibility instead of reusing transmuter.deposit
Summary
Use inherited _deployFunds function to maintain compatibility instead of reusing transmuter.deposit
Vulnerability Details
function _deployFunds(uint256 _amount) internal override {
transmuter.deposit(_amount, address(this));
}
function claimAndSwap(
......
transmuter.deposit(asset.balanceOf(address(this)), address(this));
}
If the parent contract or interface specifies specific behavior or calling rules for _deployFunds , using this function directly can ensure that you follow these rules and keep the contract's behavior consistent with the parent contract or interface.
Impact
Does not comply with code design principles, and the logic is complicated.
Tools Used
Manual review
Recommendations
Always Use the Inherited _deployFunds Function
function claimAndSwap(
......
_deployFunds(asset.balanceOf(address(this)));
}
Prize pool breakdown
Total prize
16,653 OP
nSLOC
25366 OP / LOC
15,800
853
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.