While reviewing the StrategyOp
contract, I noticed that the variable claimable in the _harvestAndReport()
function is declared and assigned the value of transmuter.getClaimableBalance(address(this))
but is never used afterward. This unused variable increases code complexity without contributing to the functionality of the strategy.
This issue does not pose a direct security risk but could lead to unnecessary gas consumption due to the function call and might confuse developers maintaining the contract. It could also indicate incomplete implementation or leftover code from prior iterations.
VS code / Manual Review
Remove the claimable variable if it is not needed.
Alternatively, integrate its value into the _totalAssets
calculation or document why this call is made despite not using the returned value.
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.