Submission Details
Severity:
Incomplete balance accounting in `balanceDeployed()` function leads to underreporting
Description
The balanceDeployed() function does not include the claimable WETH balance from the transmuter in its total calculation. This leads to an underreporting of the strategy's total assets since funds that could be claimed via transmuter.claim() are not counted.
The function currently only sums:
Unexchanged balance via
getUnexchangedBalance()Direct WETH balance via
underlying.balanceOf()Direct alETH balance via
asset.balanceOf()
Recommendation
Update balanceDeployed() to include the claimable balance in its sum:
function balanceDeployed() public view returns (uint256) {
return transmuter.getUnexchangedBalance(address(this)) +
transmuter.getClaimableBalance(address(this)) +
underlying.balanceOf(address(this)) +
asset.balanceOf(address(this));
}
Updates
Appeal created
inallhonesty 6 months ago
Submission Judgement Published Assigned finding tags:
balanceDeployed should include claimable
inallhonesty
6 months ago
Prize pool breakdown
Total prize
16,653 OP
nSLOC
25366 OP / LOC
15,800
853
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.