Summary

The claimAndSwap function in the StrategyOp contract contains a potential bug when _amountClaim == 0. In this case, the function performs unnecessary operations.

Vulnerability Details

https://github.com/Cyfrin/2024-12-alchemix/blob/82798f4891e41959eef866bd1d4cb44fc1e26439/src/StrategyOp.sol#L79

This results in a swap operation where the amount being swapped is 0. While this might not perform a "real" swap, it still interacts with the router, and depending on the implementation of the router, this could trigger changes in internal state or balances, leading to unintended behavior.

Impact

Executing a swap with 0 tokens can trigger internal state changes or balance shifts in the router or related contracts, which could lead to incorrect balances or other unintended effects.

Tools Used

Recommendations

The following code must be added.