Using `safeApprove` in StrategyOp will cause contract to not work with latest OZ version as it is deprecated.
Summary
The `StrategyMainnet` uses safeApprove function which is deprecated in the new version of OpenZeppelin as stated in version 4.8.0:
https://github.com/OpenZeppelin/openzeppelin-contracts/blob/49c0e4370d0cc50ea6090709e3835a3091e33ee2/contracts/token/ERC20/utils/SafeERC20.sol#L40
Furthermore it is unsafe and it's usage is discouraged.
Vulnerability Details
Usage of `safeApprove`:
As stated in the OZ documentation:
This function has issues similar to the ones found in
{IERC20-approve}, and its usage is discouraged.
Whenever possible, use {safeIncreaseAllowance} and
{safeDecreaseAllowance} instead.
Impact
Protocol will not work with latest OZ libraries.
Usage of safeApprove is strongly discouraged.
Tools Used
Manual review.
Recommendations
As stated in the OZ documentation , it is better to use safeIncreaseAllowance
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.