Alchemix Transmuter

Summary

A malicious actor could manipulate the StrategyMainnet::balanceDeployed, StrategyArb::balanceDeployed and StrategyOp::balanceDeployed by depositing either the underlying or asset token into the strategy contract.

Vulnerability Details

The protocol has a balanceDeployed function in all three contracts, which allows the protocol / anyone to view the current state of balance deployed.

However, due to the use of balanceOf(address(this)), it makes the contract susceptible to donation attack, manipulating the balanceDeployed value.

Impact

This function is likely to be used by protocol, protocol's keeper and users, returning a false value could hinder the operations of off-chain mechanim of the protocol.

Tools Used

Manual Review

Recommendations

It is recommmended to directly fetch values from the transmuter itself.