DeFiFoundrySolidity
16,653 OP
View results
Submission Details
Severity: low
Invalid

L1- Comment Transmutter claim function

Summary

In the current code, the function to claim from the Transumtter is commented.

See: https://github.com/Cyfrin/2024-12-alchemix/blob/main/src/StrategyMainnet.sol#L181

uint256 claimable = transmuter.getClaimableBalance(address(this));
if (claimable > 0) {
// transmuter.claim(claimable, address(this));
}

As we are lacking of documentation, we do not know if it is the expected code implementation. Notice also a lot of dead code, which could be helpful to remove if it is not needed.

Impact

Low if it is as expected.

Tools Used

Recommendations

Please, review your code and remove unused part, especially here as we do not understand why you are doing a check before. Would be nice also to remove all the unused code, and if possible document it. Thank you.

Updates

Appeal created

inallhonesty Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Too generic

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.