Submission Details
Severity:
Unlimited Router approval
Vulnerability Details
The setRouter function in the StrategyArb contract approves an unlimited allowance for the new router without revoking the previous router's allowance. This can lead to potential security risks if the previous router is compromised or maliciously used.
function setRouter(address _router) external onlyManagement {
router = _router;
underlying.safeApprove(router, type(uint256).max);
}
Impact
The previous router can still spend all the tokens when a new router has been setup, which can be exploited if the router is compromised.
If an old router is compromised, it can drained all the tokens.
Tools Used
manual review
Recommendations
implement a removal of the old router approval before granting approval to the new router
Updates
Appeal created
inallhonesty 5 months ago
Submission Judgement Published Assigned finding tags:
Old router approval is not revoked after an update
inallhonesty 5 months ago
Submission Judgement Published Assigned finding tags:
Old router approval is not revoked after an update
Prize pool breakdown
Total prize
16,653 OP
nSLOC
25366 OP / LOC
15,800
853
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.