DeFiFoundrySolidity
16,653 OP
View results
Submission Details
Severity: low
Invalid

IVeloRouter uses route instead of Route, which could lead to confusion.

Summary

IVeloRouter defines the interface for interacting with the Velo Router. However, the struct that defines the route is named route (lowercase) instead of Route (capitalized), leading to potential confusion within the protocol.

Vulnerability Details

The IVeloRouter interface defines the route struct as follows:

struct route {
address from;
address to;
bool stable;
address factory;
}

In Velodrome, within IRouter.sol, the router's struct is defined as follows:

struct Route {
address from;
address to;
bool stable;
address factory;
}

As you can see, the struct is defined as route in the protocol but as Route in Velodrome. This discrepancy in the struct's definition can cause confusion.

Impact

The route struct is not defined with the same name as in Velodrome, which could lead to confusion.

Tools Used

Manual review.

Recommendations

To avoid confusion, define the route struct as Route in IVeloRouter instead of route.

Updates

Appeal created

inallhonesty Lead Judge 8 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.