_harvestAndReport assumes ALETH is 1:1 with ETH
Summary
_harvestAndReport and balanceDeployed gets the totalAssuets by adding the unexchanged balance, the current asset balance and the underlying balance of the contract.
The issue is that unexchanged (transmuter.getUnexchangedBalance(address(this))) and asset.balanceOf is in ALETH, whereas the underlying balance is in ETH.
Also, ETH and ALETH is not 1:1 yet (although the ideal case it is supposed to be). The total assets calculated will be slightly different.
For example, if ALETH is worth 0.95WETH, and the contract has 100 ALETH and 100 WETH, the total assets would return 200 when it should be 195.
Impact
Calculation of total assets will be slightly different from actual.
Tools Used
Manual Review
Recommendations
Use an oracle to convert ALETH to WETH price.
Appeal created
balanceDeployed() and _harvestAndReport() add WETH and alETH, but they have different prices
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.