DeFiFoundrySolidity
16,653 OP
View results
Submission Details
Severity: medium
Invalid

logic error

Summary

Vulnerability details

https://github.com/Cyfrin/2024-12-alchemix/blob/82798f4891e41959eef866bd1d4cb44fc1e26439/src/StrategyOp.sol#L98

in the swapunderlyingtoasset function the minOut is set to always be greater than the amount, there is an issue in this logic, this can lead to DOS because if after the swap a user get the same amount of token that is equal to his minout the function will revert

Impact

dos of user when the function claimandswap is called and the amount recieved from the swap is equal to the minout the function will revert

Tools Used

manual

Recommendations

set the minout to be greater or equal to amount, so even if the amount recieved from the swap is equal to the minout the function will not revert

Updates

Appeal created

inallhonesty Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.