Alchemix Transmuter

Summary

Vulnerability details

https://github.com/Cyfrin/2024-12-alchemix/blob/82798f4891e41959eef866bd1d4cb44fc1e26439/src/StrategyOp.sol#L48

the setrouter function is used to set a new router is the router wants to be upgraded, the issue in this function is that the function lacks a check from preventing the router from being sent to a zero address, missing zero check

Impact

1. Loss of Functionality: If the router is set to the zero address, any subsequent calls that rely on the router for functionality will fail, as the zero address cannot perform any operations.

Tools Used

Recommendations

require(_router != address(0)