Submission Details
Severity:
No Duplicate Check in addRoute Function
Summary
The addRoute function allows the addition of new routes for Curve swaps but lacks a check to prevent duplicate routes. This could lead to redundant or conflicting routes being added, increasing gas usage and potentially causing unintended behavior during swaps.
https://github.com/Cyfrin/2024-12-alchemix/blob/main/src/StrategyMainnet.sol#L56
Tools Used
Manual
Recommendations
Add a check to ensure that the _route being added does not already exist:
for (uint256 i = 0; i < nRoutes; i++) {
require(
keccak256(abi.encode(routes[i])) != keccak256(abi.encode(_route)),
"Route already exists"
);
}
Prize pool breakdown
Total prize
16,653 OP
nSLOC
25366 OP / LOC
15,800
853
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.