Submission Details
Severity:
Missing Functionality to `Update` or `Remove` Route in StrategyMainnet.sol
Summary:
We can add routes using the addRoute function but there is no functionality to update or remove routes.
Vulnerability Details:
In StrategyMainnet.sol , its having a function named as addRoute
function addRoute(
address[11] calldata _route,
uint256[5][5] calldata _swapParams,
address[5] calldata _pools
) external onlyManagement {
routes[nRoutes] = _route;
swapParams[nRoutes] = _swapParams;
pools[nRoutes] = _pools;
nRoutes++;
}
Allows to add a new path to be passed into Router for swap.
We can see there is functionality to add a new Route but there is no functionality to remove or update a route.
Tools Used
Manual Review
Recommendations
Add functionality to update or remove route.
Updates
Appeal created
inallhonesty 6 months ago
Submission Judgement Published Assigned finding tags:
Cannot Set A New Router In `StrategyMainnet.sol`
Prize pool breakdown
Total prize
16,653 OP
nSLOC
25366 OP / LOC
15,800
853
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.