DeFiFoundrySolidity
16,653 OP
View results
Submission Details
Severity: medium
Invalid

bad totalAsset accounting in _harvestAndReport

Summary

bad totalAsset accounting, it is mixing WETH and alETH but should return only alETH in the 3 strategies: mainnet, arb and op

uint analysis

_totalAssets = unexchanged + asset.balanceOf(address(this)) + underlyingBalance;

_totalAssets = [WETH] + [alETH] + [WETH] but documentation says it should be the underlying asset of the staretegy, so alETH.

Vulnerability Details

Impact

Bad accounting when alETH and WETH depeg which is the porpuse of the strategy is to profit from depeg.

Tools Used

vs code

Recommendations

Normalize accounting to the underlying of the strategy

Updates

Appeal created

inallhonesty Lead Judge 5 months ago
Submission Judgement Published
Invalidated
Reason: Too generic

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.