Submission Details
Severity:
claimAndSwap function deposit all assets after swap
Summary
In claimAndSwap functions of StrategyArb.sol, StrategyMainnet.sol and StrategyOp.sol files
After swap, deposit all assets
require((balAfter - balBefore) >= _minOut, "Slippage too high");
transmuter.deposit(asset.balanceOf(address(this)), address(this));
The function needs to deposit only amount swapped.
Impact
The user might want to keep some assets in their pocket.
However, after claimAndSwap, the transmuter forcibly deposits all assets.
Tools Used
Manual
Recommendations
Need to deposit only amount chaned.
require((balAfter - balBefore) >= _minOut, "Slippage too high");
-- transmuter.deposit(asset.balanceOf(address(this)), address(this));
++ transmuter.deposit(balAfter - balBefore, address(this));
Prize pool breakdown
Total prize
16,653 OP
nSLOC
25366 OP / LOC
15,800
853
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.