Christmas Dinner

First Flight #31
Beginner FriendlyFoundrySolidity
100 EXP
View results
Submission Details
Severity: low
Invalid

[L-3] Missing event emission for deadline changes

Summary

While the contract emits an event for setting the deadline, it doesn't emit events for important state changes around the deadline.

Vulnerability Details

The contract lacks events for deadline-related state changes:

function setDeadline(uint256 _days) external onlyHost {
if(deadlineSet) {
revert DeadlineAlreadySet();
} else {
deadline = block.timestamp + _days * 1 days;
emit DeadlineSet(deadline);
}
}

Impact

  • Low: Harder to track deadline-related changes off-chain

  • Reduced transparency for event timing

Tools Used

  • Manual code review

Recommendations

Add more granular deadline events:

event DeadlineApproaching(uint256 timeRemaining);
event DeadlinePassed();
function setDeadline(uint256 _days) external onlyHost {
if(deadlineSet) {
revert DeadlineAlreadySet();
} else {
deadline = block.timestamp + _days * 1 days;
deadlineSet = true;
emit DeadlineSet(deadline);
}
}
Updates

Lead Judging Commences

0xtimefliez Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
0xtimefliez Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.