Submission Details
Severity:
Improper Implementation of Reentrancy Guard
Summary
The nonReentrant modifier is incorrectly implemented, missing the critical locked = true statement.
Vulnerability Details
modifier nonReentrant() {
require(!locked, "No re-entrancy");
//@audit should set locked to true `locked = true;`
_;
locked = false;
}
The modifier checks if the contract is locked but never sets it to locked state before executing the function.
Impact
High - This allows reentrancy attacks on protected functions like refund(), potentially draining the contract's funds.
Tools Used
Manual review
Recommendations
modifier nonReentrant() {
require(!locked, "No re-entrancy");
//@audit should set locked to true `locked = true;`
_;
locked = false;
}
Updates
Lead Judging Commences
0xtimefliez about 1 year ago
Submission Judgement Published Assigned finding tags:
mutex lock incomplete
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.