Christmas Dinner
First Flight #31
Beginner FriendlyFoundrySolidity
100 EXP
View results
Previous Next
Submission Details
Severity: low
Invalid

Potential for Sign-Up Confusion

m3dython

Location

function deposit(address _token, uint256 _amount) external beforeDeadline {
// ...
if (participant[msg.sender]) {
// ...
emit GenerousAdditionalContribution(msg.sender, _amount);
} else {
// ...
emit NewSignup(msg.sender, _amount, getParticipationStatus(msg.sender));
}
}

Issue

  • Multiple sign-ups or repeated deposits from the same address are allowed. This is presumably desired (e.g., “GenerousAdditionalContribution”), but it can create confusion about who is truly participating at which deposit.

Impact

  • Not necessarily a security hole, but the logic around “NewSignup” vs. “GenerousAdditionalContribution” might cause confusion in front-end or analytic tools if not carefully tracked.

Recommendation

  • Keep as-is but clarify in documentation and event monitoring that participants can deposit multiple times.

  • Alternatively, rename events for clarity or track first-time deposit vs. subsequent donations more distinctly.

Updates

Lead Judging Commences

0xtimefliez Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Design choice

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!