Submission Details
Severity:
`DeadlineSet` is Not Set to True When Deadline is Set, Causing Information Discrepancies
Vulnerability Details
Users are expected to be notified when the deadline is set by checking the global variable deadlineSet, which should return true if the deadline is set, or false otherwise. However, when the host sets the deadline, the deadlineSet variable is not updated, causing it to incorrectly return false even though the deadline has already been set.
Here is vulnerable code:
function setDeadline(uint256 _days) external onlyHost {
if (deadlineSet) {
revert DeadlineAlreadySet();
} else {
// @audit missing deadlineSet set to true
deadline = block.timestamp + _days * 1 days;
emit DeadlineSet(deadline);
}
}
Impact
Users may receive incorrect information from the deadlineSet variable, and the host can change the date without notice.
Recommended Mitigation
To fix this issue, consider update the deadlineSet variable to true when deadline is set.
function setDeadline(uint256 _days) external onlyHost {
if (deadlineSet) {
revert DeadlineAlreadySet();
} else {
+ deadlineSet = true;
deadline = block.timestamp + _days * 1 days;
emit DeadlineSet(deadline);
}
}
Updates
Lead Judging Commences
0xtimefliez about 1 year ago
Submission Judgement Published Assigned finding tags:
deadline is never set to true
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.