Submission Details
Severity:
nonReentrant() modifier does not work
Summary
Rentrant modifier is never set to true. Every require check will pass because locked will also be false. Thus, the modifier will never prevent re-entrancy. Affects refund() as well as internal functions _refundERC20() and _refundETH(). Contract does not import reentrancyGuard.sol from OZ.
Vulnerability Details
modifier nonReentrant() { //@audit - broken modifier. locked never = true.
require(!locked, "No re-entrancy");
_;
locked = false;
}
Impact
refund() function can be re-entered. Subsequent internal functions _refundERC20 and _refundETH are also affected.
Tools Used
Manual Review
Recommendations
Directly import and implement reentrancyGuard.sol from OZ.
Updates
Lead Judging Commences
0xtimefliez about 1 year ago
Submission Judgement Published Assigned finding tags:
mutex lock incomplete
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.