Christmas Dinner

[H-1] `ChristmasDinner:: modifier nonReentrant` The provided nonReentrant modifier is incorrect and does not properly prevent re-entrancy attacks.

​

​

**Description:** in the `modifier` function, the locked state is only checked at the start,but it is reset to false after the function logic.

That is the locked variable is reset to false after the function logic (_), meaning the contract remains vulnerable during execution

​

​

modifier nonReentrant() {

​

​

​

**Impact:** This implementation defeats the purpose of a re-entrancy guard. If an attacker can re-enter the function before locked is set back to false, they could exploit the contract draining funds or causing unintended behavior.

​

​

​

**Recommended Mitigation:**

1. consider using Openzeppelin's ReentrancyGuard implementation

2.

3. The locked state should be set to true immediately before the function logic (_) and reset to false only after the logic is executed. A proper implementation should look like this:

​

modifier nonReentrant() {

+ locked = true; // Set lock before the function execution

}