Christmas Dinner

First Flight #31
Beginner FriendlyFoundrySolidity
100 EXP
View results
Submission Details
Severity: medium
Valid

deadlineSet not updated after deadline is updated

Summary

deadlineSetis not updated to true after the deadline has been initialized to a value.

Vulnerability Details

function setDeadline(uint256 _days) external onlyHost {
if(deadlineSet) {
revert DeadlineAlreadySet();
} else {
//@audit deadlineSet not set to true
@> deadline = block.timestamp + _days * 1 days;
emit DeadlineSet(deadline);
}
}

Tools Used

Manual Review

Recommendations

The protocol should consider removing it, since there is a function setDeadlinethat allows the Host to change the deadline multiple times. If the deadlineSet is retained and used appropraitely, then the Host can update the deadlinejust once.

Updates

Lead Judging Commences

0xtimefliez Lead Judge about 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

deadline is never set to true

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!