Christmas Dinner

First Flight #31
Beginner FriendlyFoundrySolidity
100 EXP
View results
Submission Details
Severity: low
Invalid

_refundETH and _refundERC20 should still follow CEI regardless of mutex lock used in refund()

Summary

smart contracts which utilize tokens that can cause reentrancy should always follow CEI for maximum security of the user funds and the protocol funds. In this contract the nonreentrant modifier is broken and could lead to draining of user and protocol funds.

Tools Used

Manual review

Updates

Lead Judging Commences

0xtimefliez Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!