Submission Details
Severity:
Improper nonReentrant Modifier Implementation
Summary
The nonReentrant modifier resets the locked state to false after executing the function, which does not correctly protect against nested reentrant calls.
Vulnerability Details
If the function guarded by nonReentrant indirectly calls another function using the same modifier, it will reset locked to false, re-enabling reentrancy during execution.
Impact
Allows attackers to exploit reentrancy vulnerabilities, potentially draining funds or manipulating contract state.
Tools Used
Code review.
Recommendations
Refactor the modifier to set locked to true before function execution and reset it afterward:
modifier nonReentrant() {
require(!locked, "No re-entrancy");
locked = true;
_;
locked = false;
}
Updates
Lead Judging Commences
0xtimefliez about 1 year ago
Submission Judgement Published Assigned finding tags:
mutex lock incomplete
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.