Submission Details
Severity:
Host Unable to Withdraw Ether After Deadline in Contract
Vulnerability Details
The smart contract contains a vulnerability where the host is unable to withdraw Ether locked in the contract after the deadline has passed. Despite invoking the withdraw function, the Ether balance of the contract remains unchanged, preventing the host from accessing the funds collected for the event.
Impact
The Ether collected for the event remains locked in the contract, rendering it inaccessible to the host, which defeats the purpose of fund collection.
Tools Used
Foundry , VS Code
POC
function test_etherlockedInContract() public {
address dummyUser = makeAddr('786');
vm.deal(dummyUser, 10e18);
vm.startPrank(dummyUser);
(bool sendEther,) = address(cd).call{value: 10e18}("");
require(sendEther,"Failed to send ether");
vm.stopPrank();
uint256 etherBalanceBefore = address(cd).balance;
vm.startPrank(deployer);
vm.warp(DEADLINE + 1);
cd.withdraw();
vm.stopPrank();
uint256 etherBalanceAfter = address(cd).balance;
// adeployer means host not able to withdraw the funds
assertEq(etherBalanceBefore, etherBalanceAfter);
}
parwej@90CXC:/mnt/d/my Docs/2024-12-christmas-dinner$ forge test --mt test_etherlockedInContract
[⠒] Compiling...
[⠆] Compiling 1 files with Solc 0.8.28
[⠔] Solc 0.8.28 finished in 594.08ms
Compiler run successful!
Ran 1 test for test/ChristmasDinnerTest.t.sol:ChristmasDinnerTest
[PASS] test_etherlockedInContract() (gas: 81986)
Suite result: ok. 1 passed; 0 failed; 0 skipped; finished in 862.57µs (130.25µs CPU time)
Ran 1 test suite in 50.14ms (862.57µs CPU time): 1 tests passed, 0 failed, 0 skipped (1 total tests)
## Recommendations
function withdraw() external onlyHost {
address _host = getHost();
+ (bool success,) host.call{value: address(this).balance}("");
+ require(sucess,"failed to send ether");
i_WETH.safeTransfer(_host, i_WETH.balanceOf(address(this)));
i_WBTC.safeTransfer(_host, i_WBTC.balanceOf(address(this)));
i_USDC.safeTransfer(_host, i_USDC.balanceOf(address(this)));
}
Updates
Lead Judging Commences
0xtimefliez about 1 year ago
Submission Judgement Published Assigned finding tags:
withdraw function lacks functionality to send ether
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.