Submission Details
Severity:
setDeadline() does not Update deadlineSet to True
Summary
The setDeadline() never sets the deadlineSet boolean variable to true. This means the host can change the deadline as many times as they like.
Vulnerability Details
function setDeadline(uint256 _days) external onlyHost {
if(deadlineSet) {
revert DeadlineAlreadySet();
} else {
deadline = block.timestamp + _days * 1 days;
emit DeadlineSet(deadline);
}
}
Impact
The impact of not setting the deadlineSet boolean to true after calling setDeadline() is that the host can change the deadline as many time as they like.
Tools Used
Manual review.
Recommendations
See line 5 implementation below:
function setDeadline(uint256 _days) external onlyHost {
if(deadlineSet) {
revert DeadlineAlreadySet();
} else {
deadlineSet = true; //@audit - implement this line.
deadline = block.timestamp + _days * 1 days;
emit DeadlineSet(deadline);
}
}
Updates
Lead Judging Commences
0xtimefliez about 1 year ago
Submission Judgement Published Assigned finding tags:
deadline is never set to true
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.