Submission Details
Severity:
else block can be removed from setDeadline()
Summary
else block in setDeadline() is not required.
Vulnerability Details
function setDeadline(uint256 _days) external onlyHost {
if(deadlineSet) {
revert DeadlineAlreadySet();
} else {//@audit - unnecessary else block....
deadline = block.timestamp + _days * 1 days;
emit DeadlineSet(deadline);
}
}
Impact
It is redundant and unnecessary code:
Tools Used
Manual review
Recommendations
Refactor as follows :
function setDeadline(uint256 _days) external onlyHost {
if(deadlineSet) {
revert DeadlineAlreadySet();
}
deadline = block.timestamp + _days * 1 days;
emit DeadlineSet(deadline);
}
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.