Submission Details
Severity:
nonReentrant modifier missing mutex lock
Summary
The nonReentrant modifier is missing the mutex lock. This means the state of locked isn't set to true before the execution of the function _ to then be set to false, thus fulfilling the purpose of the modifier.
Impact
refund() uses the nonReentrant modifier to prevent someone taking all the funds with a reentrancy, and by failing to do so, all the funds locked within the contract are at risk.
Recommendations
Set the locked modifier to true within the nonReentrant modifier as follows:
modifier nonReentrant() {
require(!locked, "No re-entrancy");
++ locked = true;
_;
locked = false;
}
Updates
Lead Judging Commences
0xtimefliez about 1 year ago
Submission Judgement Published Assigned finding tags:
mutex lock incomplete
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.