Submission Details
Severity:
Reentrancy Vulnerability in nonReentrant Modifier
Summary
The nonReentrant modifier incorrectly resets the locked variable to false before the function exits, potentially enabling reentrancy attacks.
Vulnerability Details
The nonReentrant modifier sets locked to false after the function execution (_). This is incorrect and may allow reentrancy attacks because the locked variable is reset before exiting the function.
Impact
loss of funds due to reentrancy attack.
Tools Used
mannual checks
Recommendations
Set locked to true before executing the function body and reset it to false after the execution
modifier nonReentrant() {
require(!locked, "No re-entrancy");
+ locked = true;
_;
locked = false;
}
Updates
Lead Judging Commences
0xtimefliez 11 months ago
Submission Judgement Published Assigned finding tags:
mutex lock incomplete
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.