Submission Details
Severity:
withdraw() function doesn't send Ether to host, which leads to having Ether locked forever
Summary
While withdraw()withdraws all ERC20s, it does not withdraw Ether, which gets locked in the contract forever after deadline passes.
Vulnerability Details
After deadline, the refund() function is no longer callable because of the beforeDeadline modifier, leaving withdraw() as the only option to withdraw funds from the contract. However, this function only withdraws ERC20s, and not the Ether locked in the contract.
Recommendations
Add a ether transfer to the withdraw function:
function withdraw() external onlyHost {
address _host = getHost();
++ payable(_host).transfer(address(this).balance);
i_WETH.safeTransfer(_host, i_WETH.balanceOf(address(this)));
i_WBTC.safeTransfer(_host, i_WBTC.balanceOf(address(this)));
i_USDC.safeTransfer(_host, i_USDC.balanceOf(address(this)));
}
Updates
Lead Judging Commences
0xtimefliez 11 months ago
Submission Judgement Published Assigned finding tags:
withdraw function lacks functionality to send ether
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.