Christmas Dinner

First Flight #31
Beginner FriendlyFoundrySolidity
100 EXP
View results
Submission Details
Severity: low
Invalid

Inconsistent Balance Management

Description: The contract handles ETH and ERC20 balances differently (separate mappings).

Impact: Could lead to maintenance issues and potential bugs in future updates.

Recommended Mitigation: Unify the balance tracking system using a single mapping structure:

mapping(address user => mapping(address token => uint256 balance)) public balances;
// Use address(0) for ETH
Updates

Lead Judging Commences

0xtimefliez Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
0xtimefliez Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.