Christmas Dinner

First Flight #31
Beginner FriendlyFoundrySolidity
100 EXP
View results
Submission Details
Severity: medium
Valid

Host could set deadline multiple times

Summary

The setDeadline function fails to update the deadlineSet boolean after setting the deadline, allowing multiple deadline updates when it should only be settable once.

Vulnerability Details

  • deadlineSet remains false after setting deadline

  • Check if(deadlineSet) becomes ineffective

  • Allows repeated deadline modifications

Impact

Host can set deadline multiple times despite intended one-time setting

  • Previous deadline values can be overwritten

  • Breaks the business logic of immutable deadlines

Tools Used

Manual Review

Recommendations

function setDeadline(uint256 _days) external onlyHost {
if(deadlineSet) {
revert DeadlineAlreadySet();
}
deadline = block.timestamp + _days * 1 days;
deadlineSet = true; //this needs to be done
emit DeadlineSet(deadline);
}
Updates

Lead Judging Commences

0xtimefliez Lead Judge 10 months ago
Submission Judgement Published
Validated
Assigned finding tags:

deadline is never set to true

0xtimefliez Lead Judge 10 months ago
Submission Judgement Published
Validated
Assigned finding tags:

deadline is never set to true

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.