Submission Details
Severity:
The `nonReentrant` modifier is written in an incorrect way
Description
The nonReentrant modifier sets locked = false after function execution but does not set locked = true at the start.
Impact
The reentrancy protection is incomplete, allowing potential reentrant calls before the modifier sets locked = false.
Proof of Concepts
The value of the
lockedvariable isfalseas per L::43Hence the
require(!locked, "No re-entrancy");statement in the modifier will always pass, not protecting for reentrancy.
Recommended mitigation
Add the following change to the code.
modifier nonReentrant() {
require(!locked, "No re-entrancy");
+ locked = true;
_;
locked = false;
}
Updates
Lead Judging Commences
0xtimefliez 10 months ago
Submission Judgement Published Assigned finding tags:
mutex lock incomplete
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.